“Neovim had changed the format of the undo files. It hadn’t upgraded the old one.”
Neovim changed its undo file format and deleted Vim’s files instead of converting them. That was user data sitting on disk. Bugs happen. Deciding someone else’s files are disposable is a choice.